Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test setup for content bundle integration #692

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Aug 8, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs removed old setup in #691
License MIT

What's in this PR?

Add article test template setup.

Why?

We cleanup the repository in #691 but we require some basic template for the new tests then.

@alexander-schranz alexander-schranz changed the title Add article test template setup Add article test setup for content bundle integration Aug 8, 2024
@alexander-schranz alexander-schranz force-pushed the feature/new-article-template branch 2 times, most recently from 035f346 to 661b094 Compare August 8, 2024 12:22
@alexander-schranz alexander-schranz added the Feature New functionality not yet included label Aug 8, 2024
@alexander-schranz alexander-schranz changed the title Add article test setup for content bundle integration Add test setup for content bundle integration Aug 8, 2024
@alexander-schranz alexander-schranz force-pushed the feature/new-article-template branch from 929170a to b755a9f Compare August 8, 2024 13:04
@alexander-schranz
Copy link
Member Author

@Prokyonn did not create a phpstan baseline to make sure that we have a look at them soonish.

@alexander-schranz alexander-schranz marked this pull request as ready for review August 8, 2024 13:18
@alexander-schranz alexander-schranz force-pushed the feature/new-article-template branch from f4872d3 to a099d79 Compare August 8, 2024 14:05
@alexander-schranz alexander-schranz merged commit 22ece71 into sulu:3.0 Aug 8, 2024
5 of 6 checks passed
@alexander-schranz alexander-schranz deleted the feature/new-article-template branch August 8, 2024 14:09
@alexander-schranz alexander-schranz restored the feature/new-article-template branch August 8, 2024 14:10
@alexander-schranz
Copy link
Member Author

reverted this and squash merged this PR in #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant